Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug and added cache for SpriteSheetBuilder #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed bug and added cache for SpriteSheetBuilder #942

wants to merge 2 commits into from

Conversation

tynrare
Copy link

@tynrare tynrare commented Mar 15, 2018 •
edited
Loading

  1. Was simple bug with bitmapCache.getDataURL()->bitmapCache.getCacheDataURL()
  2. I've added canvas-to-image conversion in SpriteSheetBuilder. It allows WebGLRenderingContext._drawBuffers() to work bit faster.
    P.S. I still have lot of freezes in gl bufferSubData.
    P.P.S. Sorry for empty lines changes

@lannymcnie
Copy link
Member

We are considering this PR, but the commit has a bunch of additional formatting. If you can remove it, we can review.

@lannymcnie
Copy link
Member

Considering the very last lines of this PR (the actual image swap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tynrare @lannymcnie